Skip to content

Adjust oneAPI.jl __init__ on Windows#580

Merged
michel2323 merged 1 commit into
JuliaGPU:mainfrom
wheeheee:quickfix_win_init
Jun 23, 2026
Merged

Adjust oneAPI.jl __init__ on Windows#580
michel2323 merged 1 commit into
JuliaGPU:mainfrom
wheeheee:quickfix_win_init

Conversation

@wheeheee

Copy link
Copy Markdown
Contributor

Quick and dirty but hopefully fixes #448.

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.93%. Comparing base (1cd7f81) to head (e511956).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/oneAPI.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files          48       48           
  Lines        3237     3237           
=======================================
  Hits         2620     2620           
  Misses        617      617           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wheeheee

Copy link
Copy Markdown
Contributor Author

Seems like the tests passed. After having a look at oneL0's init though, it appears that oneL0.functional[] is set to true only after isavailable() is checked, so this one here seems redundant. Is there any reason to check it again or should I just remove it

@michel2323

Copy link
Copy Markdown
Member

You're right, it's redundant today. But who knows in the future. It doesn't cost anything.

@michel2323 michel2323 merged commit f0bc493 into JuliaGPU:main Jun 23, 2026
4 checks passed
@wheeheee wheeheee deleted the quickfix_win_init branch June 23, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: first call to using oneAPI errors, terminates testing; second call succeeds

2 participants